Toggle Polling from the UI

[Skarlso]

No description provided.

[Skarlso]

@michelvocks I might have to pick your brain on how to go about with a Toggle button. I want to get its state and set it to green or something based on the state of the config. And then toggling that will change the config value.

[codecov-io]

Codecov Report

Merging #174 into master will decrease coverage by 0.12%.
The diff coverage is 63%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   66.82%   66.69%   -0.13%     
==========================================
  Files          33       35       +2     
  Lines        2607     2681      +74     
==========================================
+ Hits         1742     1788      +46     
- Misses        642      671      +29     
+ Partials      223      222       -1

Impacted Files	Coverage Δ
store/settings.go	0% <0%> (ø)
handlers/handler.go	85.96% <100%> (+0.77%)	⬆️
store/store.go	67.56% <50%> (-1.01%)	⬇️
handlers/settings.go	70.21% <70.21%> (ø)
workers/pipeline/ticker.go	50% <89.28%> (+13.49%)	⬆️
workers/pipeline/git.go	69.33% <0%> (-2.8%)	⬇️
handlers/pipeline.go	53.94% <0%> (-2.31%)	⬇️
workers/pipeline/create_pipeline.go	44.08% <0%> (-1.47%)	⬇️
handlers/hook.go	62.5% <0%> (-0.66%)	⬇️
handlers/pipeline_run.go	0% <0%> (ø)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519a2be...131b37d. Read the comment docs.

[michelvocks]

@michelvocks I might have to pick your brain on how to go about with a Toggle button. I want to get its state and set it to green or something based on the state of the config. And then toggling that will change the config value.

You can use vue-bulma-switch for this. It's pretty old and not really updated but basically all our current components are based on vue-bulma so I think it makes sense.

Let me know if you need something else.

[Skarlso]

@michelvocks I might have to pick your brain on how to go about with a Toggle button. I want to get its state and set it to green or something based on the state of the config. And then toggling that will change the config value.

You can use vue-bulma-switch for this. It's pretty old and not really updated but basically all our current components are based on vue-bulma so I think it makes sense.

Let me know if you need something else.

Cool, thanks!

[Skarlso]

Uh, we will have to eventually take this apart into smaller files or something. Navigating this view is becoming difficult. :) I don't know how vue works but that should be possible. :)

[Skarlso]

Oh! I see how permissions did it. I'll do that same. :) Extract settings into there. Nice.

[Skarlso]

@michelvocks This looks like shit right now. :D But actually works. :) the toggle and all work together stopping / starting the poller. :) And the button is set to on and off on mounting so it shows what the value currently is. Which is nice. :D

I also tried turning it on and off a hundred times or so quickly to see if I can break the underlying channel logic. But seems to work okay. :)

I'll try and come up with a design for this. And write some handler tests. :)

[michelvocks]

@Skarlso Cool. Looking forward to trying it out. This is also a solid foundation for additional settings 👍

[Skarlso]

@michelvocks yeah I'm trying to work out a better way of doing this 🤔 Maybe save all the possible settings in a map pointer with string keys or something. I'll do some more thinking on it. It would be cool to have something common that all the settingon-off methods could use.

You still would have get set methods for individual settings but they would use something common. But maybe it's not worth it. Don't know until I have a go at it. :) I don't want to use reflection either.

[michelvocks]

@Skarlso I think you can just use a struct like we normally do: https://github.com/gaia-pipeline/gaia/blob/master/frontend/client/views/pipeline/create.vue#L336

[Skarlso]

Yes. But the settings are of different types. And I sort of thought for something like: setSetting(name, key, string) bamm, done. :D But that's not going to work. Unless we use something like, flag.Func or something like that which takes a function and would handle conversion. Not sure yet.

[michelvocks]

I think it's easier to send all settings in a struct and check in the backend what has changed.

[Skarlso]

I was thinking about that too to just always send everything. But I don't like that. :) I would like to keep the Json size to a bare minimum. If we always send / get everything that will increase the amount of bandwidth Gaia is using.

[Skarlso]

Eh, I don't know. Maybe it's okay for now. I don't see how we'd change some of the other config settings like port of server address or working directory without the need to restart Gaia anyways. Maybe if another setting presents itself, then we'll consider refactoring.

[Skarlso]

@michelvocks found a nicer button ;)

Easier to change programatically too.

[michelvocks]

Nice! 🤗

[Skarlso]

@michelvocks Read for you man. :) Increases coverage \o/

[michelvocks]

One minor thing. Overall LGTM 👍

[michelvocks]

@Skarlso One additional thing we should think about:

What happens when you restart Gaia or it crashes? The change you made in the UI is basically lost.
This might be frustrating for users. We could save the change in the boltdb but then we have to decide which change takes precedence in case the user set an environment variable or used a configuration file.

[Skarlso]

@michelvocks Our flag implementation now supports environment files. We could write this out in that file which does take precedence.

I'm reluctant to use a dB to configure start up time configuration. The Environment file is a better choice in that case I think.

[Skarlso]

Uh, the file approach sucks because I can't really overwrite. I can search and append, or fseek. But it isn't particularly pretty. :/

I will have to resort to the DB.

[Skarlso]

Oh yeah so the question is, which one would be used first.... I'm going with the bbolt setting being of higher importance.

[Skarlso]

@michelvocks alright. this is ready for review again. I tested it manually too. Turned it on, quit Gaia, started it up again, and setting was still on. :)

[michelvocks]

LGTM. Thanks a lot @Skarlso 🤗