Refactored Gaia parameters #198
Conversation
docker/Dockerfile
Outdated
| @@ -307,7 +306,7 @@ RUN chmod +x ./gaia-linux-amd64 \ | |||
| && chmod 600 /root/.ssh | |||
|
|
|||
| # Set homepath as volume | |||
| VOLUME [ "${GAIA_HOMEPATH}" ] | |||
| VOLUME [ "${GAIA_HOME-PATH}" ] | |||
There was a problem hiding this comment.
- in environment properties is not a good thing as they usually can't be parsed nicely or cause problems on the command line in ZSH they even have to be explicitly escaped sometimes like [ or {. I would just leave this out. It's fine like that.
There was a problem hiding this comment.
We need some way to separate longer property options. My first idea was to use _ but if you pass parameters to the binary it also looks odd: -home_path
There was a problem hiding this comment.
Oh hang on that stuff is auto-read. ARGH. Okay, never mind then.
Also, yeah it should be --home-path
There was a problem hiding this comment.
I found out that flag supports that out of the box by replacing - with _ for environment variables. Perfect 😄
There was a problem hiding this comment.
Oh very awesome! :D :D Perfect. :)
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=========================================
- Coverage 62.22% 62.2% -0.03%
=========================================
Files 48 48
Lines 3934 3934
=========================================
- Hits 2448 2447 -1
- Misses 1081 1082 +1
Partials 405 405
Continue to review full report at Codecov.
|
This PR refactors Gaia's configuration parameters which had an inconsistent naming scheme and missed some important documentation.