Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate execpath from pipeline objects returned to clients #229

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

michelvocks
Copy link
Member

Fixes #226

@michelvocks michelvocks added the Ready To Merge PR is ready to be merged into master label Dec 4, 2019
@michelvocks michelvocks requested a review from Skarlso December 4, 2019 11:00
@codecov-io
Copy link

Codecov Report

Merging #229 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #229     +/-   ##
=========================================
- Coverage      62%   61.91%   -0.1%     
=========================================
  Files          49       49             
  Lines        4066     4072      +6     
=========================================
  Hits         2521     2521             
- Misses       1132     1138      +6     
  Partials      413      413
Impacted Files Coverage Δ
handlers/pipeline.go 53.64% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f272f...0cc0e4b. Read the comment docs.

@Skarlso
Copy link
Member

Skarlso commented Dec 4, 2019

Hum, are none of the workers using that for anything?

@michelvocks
Copy link
Member Author

Workers don't use the usual REST API. They use the gRPC interface.

@michelvocks michelvocks merged commit 072ded5 into gaia-pipeline:master Dec 10, 2019
@michelvocks michelvocks deleted the obfuscate_execpath branch December 10, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop sending pipeline local path to clients
3 participants