Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the docker argument in case of pipeline start #294

Merged
merged 4 commits into from
Nov 29, 2020
Merged

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Nov 28, 2020

This should close #292.

@Skarlso
Copy link
Member Author

Skarlso commented Nov 28, 2020

/test

@gaia-bot
Copy link

Command received. Building new test image.

@gaia-bot
Copy link

New version pushed. Please wait for 5 minutes for it to propagate.

@Skarlso
Copy link
Member Author

Skarlso commented Nov 28, 2020

/test

@gaia-bot
Copy link

Command received. Building new test image.

@gaia-bot
Copy link

New version pushed. Please wait for 5 minutes for it to propagate.

@Skarlso
Copy link
Member Author

Skarlso commented Nov 28, 2020

/test

@gaia-bot
Copy link

Command received. Building new test image.

@codecov-io
Copy link

codecov-io commented Nov 28, 2020

Codecov Report

Merging #294 (a923f1d) into master (da4aac4) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   58.21%   58.22%           
=======================================
  Files          58       58           
  Lines        4186     4182    -4     
=======================================
- Hits         2437     2435    -2     
  Misses       1284     1284           
+ Partials      465      463    -2     
Impacted Files Coverage Δ
providers/pipelines/pipeline.go 48.37% <0.00%> (-0.64%) ⬇️
workers/scheduler/gaiascheduler/scheduler.go 56.25% <92.85%> (+0.41%) ⬆️
handlers/vault.go 55.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4aac4...a923f1d. Read the comment docs.

@gaia-bot
Copy link

New version pushed. Please wait for 5 minutes for it to propagate.

@Skarlso
Copy link
Member Author

Skarlso commented Nov 29, 2020

/test

@gaia-bot
Copy link

Command received. Building new test image.

@gaia-bot
Copy link

New version pushed. Please wait for 5 minutes for it to propagate.

@Skarlso Skarlso merged commit 4086339 into master Nov 29, 2020
@Skarlso Skarlso deleted the issue_292 branch November 29, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gosdk pipelines with arguments fail to start
3 participants