Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slack badge to readme. #64

Merged
merged 4 commits into from
Jul 31, 2018
Merged

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Jul 28, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   53.61%   53.61%           
=======================================
  Files          14       14           
  Lines        1218     1218           
=======================================
  Hits          653      653           
  Misses        496      496           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8da40...c7e7da2. Read the comment docs.

@Skarlso
Copy link
Member Author

Skarlso commented Jul 28, 2018

Deals with #63

README.rst Outdated
@@ -225,10 +226,14 @@ If you have any questions feel free to contact us on `gitter`_.
:alt: Apache licensed
:target: https://github.com/gaia-pipeline/gaia/blob/master/LICENSE

.. |chat| image:: https://badges.gitter.im/Join%20Chat.svg
.. |chat| image:: https://badges.gitter.im/Join%20Chat.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove gitter then 😄

README.rst Outdated
@@ -186,7 +186,7 @@ If you think you found a good first issue, please consider this list as a short
Contact
=======

If you have any questions feel free to contact us on `gitter`_.
If you have any questions feel free to contact us on `gitter`_ or `slack`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us deprecate gitter. One chat is enough 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that. :D Will do. :)

@Skarlso Skarlso added the Ready To Merge PR is ready to be merged into master label Jul 30, 2018
@Skarlso Skarlso merged commit 70b3dd5 into gaia-pipeline:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants