Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused dependencies #80

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

michelvocks
Copy link
Member

@michelvocks michelvocks commented Aug 17, 2018

Fixes #79

@Skarlso Don't know why but a simple dep ensure removed now the packages. No clue why this didn't happen with the last run 🤷‍♂️

@michelvocks michelvocks added the Ready To Merge PR is ready to be merged into master label Aug 17, 2018
@michelvocks michelvocks self-assigned this Aug 17, 2018
@michelvocks michelvocks requested a review from Skarlso August 17, 2018 15:55
@codecov-io
Copy link

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          19       19           
  Lines        1668     1668           
=======================================
  Hits         1065     1065           
  Misses        493      493           
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c57eea...43c61fd. Read the comment docs.

@Skarlso
Copy link
Member

Skarlso commented Aug 17, 2018

Interesting. 🤔 Dep is mostly magic anyways. 🤣

Copy link
Member

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO IT! :)

@michelvocks michelvocks merged commit 0351ed7 into gaia-pipeline:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants