Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed race condition on channel close while go routine was sending #85

Merged

Conversation

michelvocks
Copy link
Member

Fixes #77

@codecov-io
Copy link

Codecov Report

Merging #85 into master will decrease coverage by 0.15%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   64.59%   64.44%   -0.16%     
==========================================
  Files          22       22              
  Lines        1881     1887       +6     
==========================================
+ Hits         1215     1216       +1     
- Misses        535      539       +4     
- Partials      131      132       +1
Impacted Files Coverage Δ
scheduler/scheduler.go 73.57% <83.33%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29515f...26ba7e6. Read the comment docs.

@Skarlso
Copy link
Member

Skarlso commented Aug 22, 2018

Yep. That was my thinking on that too.

@michelvocks michelvocks merged commit 374cc8d into gaia-pipeline:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants