Allow excluding arrow functions from require-param

gajus · Aug 9, 2016 · 25c5212 · 25c5212
1 parent caebfe0
commit 25c5212
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -230,6 +230,13 @@ The following patterns are considered problems:
 (foo) => {}
 // Message: Missing "foo" parameter type annotation.
 
+function x(foo) {}
+// Message: Missing "foo" parameter type annotation.
+
+// Options: [{"excludeArrowFunctions":true}]
+function x(foo) {}
+// Message: Missing "foo" parameter type annotation.
+
 (foo = 'FOO') => {}
 // Message: Missing "foo" parameter type annotation.
 
@@ -263,6 +270,9 @@ The following patterns are not considered problems:
 
 ([foo]: Array) => {}
 
+(foo) => {}
+
+// Options: [{"excludeArrowFunctions":true}]
 (foo) => {}
 ```
 

diff --git a/src/rules/requireParameterType.js b/src/rules/requireParameterType.js
@@ -12,12 +12,15 @@ export default iterateFunctionNodes((context) => {
         return () => {};
     }
 
+    const skipArrows = _.get(context, 'options[0].excludeArrowFunctions');
+
     return (functionNode) => {
         _.forEach(functionNode.params, (identifierNode) => {
             const parameterName = getParameterName(identifierNode, context);
             const typeAnnotation = _.get(identifierNode, 'typeAnnotation') || _.get(identifierNode, 'left.typeAnnotation');
+            const shouldSkip = functionNode.type === 'ArrowFunctionExpression' && skipArrows;
 
-            if (!typeAnnotation) {
+            if (!typeAnnotation && !shouldSkip) {
                 context.report(identifierNode, 'Missing "' + parameterName + '" parameter type annotation.');
             }
         });

diff --git a/tests/rules/assertions/requireParameterType.js b/tests/rules/assertions/requireParameterType.js
@@ -8,6 +8,27 @@ export default {
                 }
             ]
         },
+        {
+            code: 'function x(foo) {}',
+            errors: [
+                {
+                    message: 'Missing "foo" parameter type annotation.'
+                }
+            ]
+        },
+        {
+            code: 'function x(foo) {}',
+            errors: [
+                {
+                    message: 'Missing "foo" parameter type annotation.'
+                }
+            ],
+            options: [
+                {
+                    excludeArrowFunctions: true
+                }
+            ]
+        },
         {
             code: '(foo = \'FOO\') => {}',
             errors: [
@@ -85,6 +106,14 @@ export default {
                     onlyFilesWithFlowAnnotation: true
                 }
             }
+        },
+        {
+            code: '(foo) => {}',
+            options: [
+                {
+                    excludeArrowFunctions: true
+                }
+            ]
         }
     ]
 };