Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files that have a comment before the @flow comment are not considered as being flow-checked #248

Closed
julienw opened this issue Jun 28, 2017 · 1 comment

Comments

@julienw
Copy link

julienw commented Jun 28, 2017

Exemple of such a file:

/*
  LICENSE information
*/
// @flow

var i: number = 3;

The problem is at https://github.com/gajus/eslint-plugin-flowtype/blob/master/src/utilities/isFlowFile.js#L17

Indeed we forcefully only handle the first comment.

I'm quite sure that flow will flow-check a file wherever the flow comment is, even if their documentation says it should appear before the first line of code. Anyway the current rule doesn't actually check this either :)

julienw added a commit to julienw/eslint-plugin-flowtype that referenced this issue Jun 28, 2017
@julienw
Copy link
Author

julienw commented Jun 29, 2017

Fixed by #240

@julienw julienw closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant