fix(no-undefined-types): handle missing comment nodes on ancestors; f…

…ixes #561
gajus · Jun 4, 2020 · 0bc67fc · 0bc67fc
1 parent eb2c2b7
commit 0bc67fc
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -6224,6 +6224,16 @@ function example(arg) {
   }
 }
 // Settings: {"jsdoc":{"mode":"closure"}}
+
+const init = () => {
+  /**
+   * Makes request
+   * @returns {Promise}
+   */
+  function request() {
+    return Promise.resolve('success');
+  }
+};
 ````
 
 

diff --git a/src/rules/noUndefinedTypes.js b/src/rules/noUndefinedTypes.js
@@ -79,6 +79,9 @@ export default iterateJsdoc(({
 
   let templateTags = _(ancestorNodes).flatMap((ancestorNode) => {
     const commentNode = getJSDocComment(sourceCode, ancestorNode, settings);
+    if (!commentNode) {
+      return [];
+    }
 
     const jsdoc = parseComment(commentNode, '');
 

diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -724,5 +724,21 @@ export default {
         },
       },
     },
+    {
+      code: `
+    const init = () => {
+      /**
+       * Makes request
+       * @returns {Promise}
+       */
+      function request() {
+        return Promise.resolve('success');
+      }
+    };
+`,
+      env: {
+        es6: true,
+      },
+    },
   ],
 };