fix(require-returns-check): ensure breaks in final switch do not fu…

…lfill check for all branches returning
gajus · Nov 2, 2022 · 691a414 · 691a414
1 parent 5fcb62e
commit 691a414
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -18321,6 +18321,22 @@ function maybeTrue() {
     return true;
   }
 }
+
+/**
+ * @param {AST} astNode
+ * @returns {AST}
+ */
+const getTSFunctionComment = function (astNode) {
+  switch (greatGrandparent.type) {
+  case 'VariableDeclarator':
+    if (greatGreatGrandparent.type === 'VariableDeclaration') {
+      return greatGreatGrandparent;
+    }
+
+  default:
+    return astNode;
+  }
+};
 ````
 
 

diff --git a/src/utils/hasReturnValue.js b/src/utils/hasReturnValue.js
@@ -189,8 +189,10 @@ const allBrancheshaveReturnValues = (node, promFilter) => {
   case 'SwitchStatement': {
     return node.cases.every(
       (someCase) => {
-        const nde = someCase.consequent.slice(-1)[0];
-        return !nde || allBrancheshaveReturnValues(nde, promFilter);
+        return !someCase.consequent.some((consNode) => {
+          return consNode.type === 'BreakStatement' ||
+            consNode.type === 'ReturnStatement' && consNode.argument === null;
+        });
       },
     );
   }

diff --git a/test/rules/assertions/requireReturnsCheck.js b/test/rules/assertions/requireReturnsCheck.js
@@ -1458,5 +1458,24 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * @param {AST} astNode
+       * @returns {AST}
+       */
+      const getTSFunctionComment = function (astNode) {
+        switch (greatGrandparent.type) {
+        case 'VariableDeclarator':
+          if (greatGreatGrandparent.type === 'VariableDeclaration') {
+            return greatGreatGrandparent;
+          }
+
+        default:
+          return astNode;
+        }
+      };
+      `,
+    },
   ],
 };