fix(check-param-names, require-param): handle ts constructor as arg; f…

…ixes #576
gajus · Jun 14, 2020 · bd11a73 · bd11a73
1 parent f29f9e2
commit bd11a73
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -2210,6 +2210,17 @@ export default function (input: {
 }): void {
   input;
 }
+
+export class Thing {
+  foo: any;
+
+  /**
+   * @param {} C
+   */
+  constructor(C: { new (): any }) {
+    this.foo = new C();
+  }
+}
 ````
 
 

diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js
@@ -71,7 +71,7 @@ const flattenRoots = (params, root = '') => {
 
 type T = string | [?string, T];
 const getPropertiesFromPropertySignature = (propSignature): T => {
-  if (propSignature.type === 'TSIndexSignature') {
+  if (propSignature.type === 'TSIndexSignature' || propSignature.type === 'TSConstructSignatureDeclaration') {
     return undefined;
   }
   if (propSignature.typeAnnotation && propSignature.typeAnnotation.typeAnnotation.type === 'TSTypeLiteral') {

diff --git a/test/rules/assertions/checkParamNames.js b/test/rules/assertions/checkParamNames.js
@@ -1125,5 +1125,20 @@ export default {
       `,
       parser: require.resolve('@typescript-eslint/parser'),
     },
+    {
+      code: `
+      export class Thing {
+        foo: any;
+
+        /**
+         * @param {} C
+         */
+        constructor(C: { new (): any }) {
+          this.foo = new C();
+        }
+      }
+      `,
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
   ],
 };