fix: Revert "fix(no-undefined-types): treat variables imported by `…

…@import` tags as defined"; fixes #1246 This reverts commit 34ba2e0. Dependency needs CJS build
gajus · Jun 23, 2024 · ce066df · ce066df
1 parent 34ba2e0
commit ce066df
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 227 deletions.
diff --git a/docs/rules/no-undefined-types.md b/docs/rules/no-undefined-types.md
@@ -307,36 +307,6 @@ const a = new Todo();
  */
 // Settings: {"jsdoc":{"structuredTags":{"namepathOrURLReferencer":{"name":"namepath-or-url-referencing"}}}}
 // Message: The type 'SomeType' is undefined.
-
-/**
- * @import BadImportIgnoredByThisRule
- */
-/**
- * @import LinterDef, { Sth as Something, Another as Another2 } from "eslint"
- */
-/**
- * @import { Linter } from "eslint"
- */
-/**
- * @import LinterDefault from "eslint"
- */
-/**
- * @import {Linter as Lintee} from "eslint"
- */
-/**
- * @import * as Linters from "eslint"
- */
-
-/**
- * @type {BadImportIgnoredByThisRule}
- */
-/**
- * @type {Sth}
- */
-/**
- * @type {Another}
- */
-// Message: The type 'BadImportIgnoredByThisRule' is undefined.
 ````
 
 
@@ -807,45 +777,8 @@ function quux(foo) {
 
 quux(0);
 
-/**
- * @import BadImportIgnoredByThisRule
- */
-/**
- * @import LinterDef, { Sth as Something, Another as Another2 } from "eslint"
- */
 /**
  * @import { Linter } from "eslint"
  */
-/**
- * @import LinterDefault from "eslint"
- */
-/**
- * @import {Linter as Lintee} from "eslint"
- */
-/**
- * @import * as Linters from "eslint"
- */
-
-/**
- * @type {LinterDef}
- */
-/**
- * @type {Something}
- */
-/**
- * @type {Another2}
- */
-/**
- * @type {Linter}
- */
-/**
- * @type {LinterDefault}
- */
-/**
- * @type {Lintee}
- */
-/**
- * @type {Linters}
- */
 ````
 
diff --git a/package.json b/package.json
@@ -11,7 +11,6 @@
     "debug": "^4.3.4",
     "escape-string-regexp": "^4.0.0",
     "esquery": "^1.5.0",
-    "parse-imports": "^2.0.0",
     "semver": "^7.6.2",
     "spdx-expression-parse": "^4.0.0"
   },

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/rules/noUndefinedTypes.js b/src/rules/noUndefinedTypes.js
@@ -1,13 +1,12 @@
-import { parseImportsSync } from 'parse-imports';
+import iterateJsdoc, {
+  parseComment,
+} from '../iterateJsdoc.js';
 import {
   getJSDocComment,
   parse as parseType,
   traverse,
   tryParse as tryParseType,
 } from '@es-joy/jsdoccomment';
-import iterateJsdoc, {
-  parseComment,
-} from '../iterateJsdoc.js';
 
 const extraTypes = [
   'null', 'undefined', 'void', 'string', 'boolean', 'object',
@@ -110,15 +109,13 @@ export default iterateJsdoc(({
       .filter(Boolean));
   }
 
-  const comments = sourceCode.getAllComments()
+  const typedefDeclarations = sourceCode.getAllComments()
     .filter((comment) => {
       return (/^\*\s/u).test(comment.value);
     })
     .map((commentNode) => {
       return parseComment(commentNode, '');
-    });
-
-  const typedefDeclarations = comments
+    })
     .flatMap((doc) => {
       return doc.tags.filter(({
         tag,
@@ -130,51 +127,6 @@ export default iterateJsdoc(({
       return tag.name;
     });
 
-
-  const importTags = /** @type {string[]} */ (comments.flatMap((doc) => {
-    return doc.tags.filter(({
-      tag,
-    }) => {
-      return tag === 'import';
-    });
-  }).flatMap((tag) => {
-    const {
-      type, name, description
-    } = tag;
-    const typePart = type ? `{${type}} `: '';
-    const imprt = 'import ' + (description
-      ? `${typePart}${name} ${description}`
-      : `${typePart}${name}`);
-
-    let imports;
-    try {
-      // Should technically await non-sync, but ESLint doesn't support sync rules;
-      //  thankfully, the Wasm load time is safely fast
-      imports = parseImportsSync(imprt);
-    } catch (err) {
-      return null;
-    }
-
-    return [...imports].flatMap(({importClause}) => {
-      /* c8 ignore next */
-      const {default: dflt, named, namespace} = importClause || {};
-      const types = [];
-      if (dflt) {
-        types.push(dflt);
-      }
-      if (namespace) {
-        types.push(namespace);
-      }
-      if (named) {
-        for (const {binding} of named) {
-          types.push(binding);
-        }
-      }
-
-      return types;
-    });
-  }).filter(Boolean));
-
   const ancestorNodes = [];
 
   let currentNode = node;
@@ -241,7 +193,6 @@ export default iterateJsdoc(({
     )
     .concat(extraTypes)
     .concat(typedefDeclarations)
-    .concat(importTags)
     .concat(definedTypes)
     .concat(/** @type {string[]} */ (definedPreferredTypes))
     .concat(

diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -558,52 +558,6 @@ export default {
         },
       },
     },
-    {
-      code: `
-        /**
-         * @import BadImportIgnoredByThisRule
-         */
-        /**
-         * @import LinterDef, { Sth as Something, Another as Another2 } from "eslint"
-         */
-        /**
-         * @import { Linter } from "eslint"
-         */
-        /**
-         * @import LinterDefault from "eslint"
-         */
-        /**
-         * @import {Linter as Lintee} from "eslint"
-         */
-        /**
-         * @import * as Linters from "eslint"
-         */
-
-        /**
-         * @type {BadImportIgnoredByThisRule}
-         */
-        /**
-         * @type {Sth}
-         */
-        /**
-         * @type {Another}
-         */
-      `,
-      errors: [
-        {
-          line: 22,
-          message: 'The type \'BadImportIgnoredByThisRule\' is undefined.',
-        },
-        {
-          line: 25,
-          message: 'The type \'Sth\' is undefined.',
-        },
-        {
-          line: 28,
-          message: 'The type \'Another\' is undefined.',
-        },
-      ],
-    },
   ],
   valid: [
     {
@@ -1484,46 +1438,9 @@ export default {
     },
     {
       code: `
-        /**
-         * @import BadImportIgnoredByThisRule
-         */
-        /**
-         * @import LinterDef, { Sth as Something, Another as Another2 } from "eslint"
-         */
         /**
          * @import { Linter } from "eslint"
          */
-        /**
-         * @import LinterDefault from "eslint"
-         */
-        /**
-         * @import {Linter as Lintee} from "eslint"
-         */
-        /**
-         * @import * as Linters from "eslint"
-         */
-
-        /**
-         * @type {LinterDef}
-         */
-        /**
-         * @type {Something}
-         */
-        /**
-         * @type {Another2}
-         */
-        /**
-         * @type {Linter}
-         */
-        /**
-         * @type {LinterDefault}
-         */
-        /**
-         * @type {Lintee}
-         */
-        /**
-         * @type {Linters}
-         */
       `,
     },
   ],