fix: Alignment fixer should use indentation character from sourceCode. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test case. |
|
Uncovered some inconsistency with how each line trimmed before evaluation while working through the test. Let me know if there's anything else with this update that should be addressed. |
- Testing: Add test cases for jsdoc blocks flush at beginning of line
|
Nice work! I've added a couple test cases to ensure we're ok flush at the beginning of a line, and those tests pass as well. If you may be so inspired to help with any other indentation-impinging issues (e.g., #369, #199 , #211, or the |
|
🎉 This PR is included in version 15.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 29, 2019
This was referenced Oct 29, 2019
Merged
Closed
Closed
This was referenced Nov 1, 2019
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #368
There were a few other areas where
' '.repeatis used that probably need to be looked into further, as I believe they apply to rules other than "check-alignment".