feat(no_proxy): allow separator with a comma and a space

gajus · Mar 31, 2021 · 5019ad7 · 5019ad7
1 parent f89883c
commit 5019ad7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/utilities/isUrlMatchingNoProxy.js b/src/utilities/isUrlMatchingNoProxy.js
@@ -11,7 +11,7 @@ import {
 export default (subjectUrl: string, noProxy: string) => {
   const subjectUrlTokens = parseUrl(subjectUrl);
 
-  const rules = noProxy.split(/[\s,]/);
+  const rules = noProxy.split(/[\s,]+/);
 
   for (const rule of rules) {
     const ruleMatch = rule

diff --git a/test/global-agent/utilities/isUrlMatchingNoProxy.js b/test/global-agent/utilities/isUrlMatchingNoProxy.js
@@ -51,6 +51,14 @@ test('returns `true` if hosts match and ports do not match (port not present NO_
   t.assert(isUrlMatchingNoProxy('http://foo.com:8000/', 'foo.com'));
 });
 
-test('returns `true` if hosts match in one of multiple rules', (t) => {
+test('returns `true` if hosts match in one of multiple rules separated with a comma', (t) => {
   t.assert(isUrlMatchingNoProxy('http://foo.com/', 'bar.org,foo.com,baz.io'));
 });
+
+test('returns `true` if hosts match in one of multiple rules separated with a comma and a space', (t) => {
+  t.assert(isUrlMatchingNoProxy('http://foo.com/', 'bar.org, foo.com, baz.io'));
+});
+
+test('returns `true` if hosts match in one of multiple rules separated with a space', (t) => {
+  t.assert(isUrlMatchingNoProxy('http://foo.com/', 'bar.org foo.com baz.io'));
+});