Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unfreeze nested children array before passing it to linkArray #293

Merged
merged 1 commit into from
Jan 3, 2019
Merged

fix: unfreeze nested children array before passing it to linkArray #293

merged 1 commit into from
Jan 3, 2019

Conversation

Xazzzi
Copy link
Contributor

@Xazzzi Xazzzi commented Jan 3, 2019

When children of decorated component happen to have nested arrays in them:

[
el1,
[el2, el3],
el4,
]

linkClass.js:86 unfreezeObject will unfreeze only 1 level in depth (i.e. first array, but not nested one), leading to TypeError: cannot assign to readonly property 0.
This PR should fix it by checking if array passed to linkArray recurse call is frozen, unfreezing if necessary.

@gajus gajus merged commit 4d6a71e into gajus:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants