Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable alignment assertions #158

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

nam-hle
Copy link
Collaborator

@nam-hle nam-hle commented Apr 22, 2021

There is some code that can not be reached in runtime in the light of the validator. Let's remove them step by step 🥰

@coveralls
Copy link

coveralls commented Apr 22, 2021

Pull Request Test Coverage Report for Build 305

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 100.0%

Totals Coverage Status
Change from base Build 303: 0.2%
Covered Lines: 335
Relevant Lines: 335

💛 - Coveralls

@nam-hle nam-hle marked this pull request as ready for review April 22, 2021 13:52
@gajus gajus merged commit 48c5bf7 into gajus:master Apr 23, 2021
@nam-hle nam-hle deleted the unreach-alignment branch April 23, 2021 00:59
@gajus
Copy link
Owner

gajus commented Apr 23, 2021

🎉 This PR is included in version 6.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 23, 2021
nam-hle added a commit to nam-hle/table that referenced this pull request Apr 23, 2021
Co-authored-by: Nam Hoang Le <nam.hoang.le@mgm-tp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants