test: add underscore test

gakonst · Oct 14, 2021 · 9fb26d5 · 9fb26d5
1 parent cb46b1a
commit 9fb26d5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/ethers-contract/tests/abigen.rs b/ethers-contract/tests/abigen.rs
@@ -2,7 +2,7 @@
 //! Test cases to validate the `abigen!` macro
 use ethers_contract::{abigen, EthEvent};
 use ethers_core::abi::{Address, Tokenizable};
-use ethers_core::types::U256;
+use ethers_core::types::{H256, U256};
 use ethers_providers::Provider;
 use std::sync::Arc;
 
@@ -193,3 +193,26 @@ fn can_handle_overloaded_functions() {
     let _ = contract.get_value_with_other_value(1337u64.into());
     let _ = contract.get_value_with_other_value_and_addr(1337u64.into(), Address::zero());
 }
+
+#[test]
+fn can_handle_underscore_functions() {
+    abigen!(
+        MyContract,
+        r#"[
+        _hashPuzzle() (uint256)
+    ]"#
+    );
+    abigen!(
+        SimpleStorage,
+        "ethers-contract/tests/solidity-contracts/simplestorage_abi.json",
+    );
+
+    let (provider, _) = Provider::mocked();
+    let client = Arc::new(provider);
+    let contract = MyContract::new(Address::zero(), client.clone());
+    // ensure both functions are callable
+    let _ = contract.hash_puzzle();
+    let _fun = contract.method::<_, H256>("_hashPuzzle", ()).unwrap();
+    let contract = SimpleStorage::new(Address::zero(), client);
+    let _fun = contract.method::<_, H256>("_hashPuzzle", ()).unwrap();
+}
diff --git a/ethers-contract/tests/solidity-contracts/SimpleStorage.sol b/ethers-contract/tests/solidity-contracts/SimpleStorage.sol
@@ -28,4 +28,6 @@ contract SimpleStorage {
         _otherValue = value2;
         lastSender = msg.sender;
     }
+
+    function _hashPuzzle() public {}
 }
diff --git a/ethers-contract/tests/solidity-contracts/simplestorage_abi.json b/ethers-contract/tests/solidity-contracts/simplestorage_abi.json
@@ -0,0 +1 @@
+[{"inputs":[{"internalType":"string","name":"value","type":"string"}],"stateMutability":"nonpayable","type":"constructor"},{"anonymous":false,"inputs":[{"indexed":true,"internalType":"address","name":"author","type":"address"},{"indexed":true,"internalType":"address","name":"oldAuthor","type":"address"},{"indexed":false,"internalType":"string","name":"oldValue","type":"string"},{"indexed":false,"internalType":"string","name":"newValue","type":"string"}],"name":"ValueChanged","type":"event"},{"inputs":[],"name":"_hashPuzzle","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[],"name":"getValue","outputs":[{"internalType":"string","name":"","type":"string"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"lastSender","outputs":[{"internalType":"address","name":"","type":"address"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"string","name":"value","type":"string"}],"name":"setValue","outputs":[],"stateMutability":"nonpayable","type":"function"},{"inputs":[{"internalType":"string","name":"value","type":"string"},{"internalType":"string","name":"value2","type":"string"}],"name":"setValues","outputs":[],"stateMutability":"nonpayable","type":"function"}]