Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Commit

Permalink
Re-enable the other field for optimism feature (#2622)
Browse files Browse the repository at this point in the history
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
  • Loading branch information
mdehoog and mattsse authored Nov 16, 2023
1 parent e1b2732 commit b4c366c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions ethers-core/src/types/transaction/optimism.rs
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ mod test {
max_priority_fee_per_gas: None,
max_fee_per_gas: None,
chain_id: None,
other: crate::types::OtherFields::default(),
};

let rlp = deposited_tx.rlp();
Expand Down
4 changes: 3 additions & 1 deletion ethers-core/src/types/transaction/response.rs
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ pub struct Transaction {
pub chain_id: Option<U256>,

/// Captures unknown fields such as additional fields used by L2s
#[cfg(not(any(feature = "celo", feature = "optimism")))]
#[cfg(not(any(feature = "celo")))]
#[serde(flatten)]
pub other: crate::types::OtherFields,
}
Expand Down Expand Up @@ -649,6 +649,8 @@ mod tests {
max_priority_fee_per_gas: None,
max_fee_per_gas: None,
chain_id: None,
#[cfg(not(feature = "celo"))]
other: crate::types::OtherFields::default(),
};

let encoded_rlp_bytes = deposited_tx.rlp();
Expand Down

0 comments on commit b4c366c

Please sign in to comment.