This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: windows ipc provider (named pipe) #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S.: CI needs quite the revamp, it's currently only covering Windows with no features and Linux with either all or no features; |
mattsse
reviewed
Dec 27, 2022
the tests are the same as websockets, do you want me to change from geth to anvil? |
Closed
|
we currently only do ipc e2e testing on unix for anvil with this we can remove the cfg and it should also work on windows, so would be great to test this first via a PR with patched ethers |
|
Oh I see what you mean now, on it |
mattsse
suggested changes
Dec 27, 2022
mattsse
approved these changes
Jan 1, 2023
|
nice work :) |
Rjected
pushed a commit
to Rjected/ethers-rs
that referenced
this pull request
Jan 4, 2023
* fmt: imports * fix: ipc tests * fmt * chore: move ws macros * chore: gate ipc to unix family * chore: make tokio optional * feat: initial named_pipe * feat: windows ipc * chore: update Provider * chore: clippy * chore: use Path instead of OsStr * chore: clippy * fix: docs * lf * lf * test: better subscription tests * docs * fix: ipc doctest * chore: make winapi optional * fix: optional tokio
|
Thank you team! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1974, cc @CodeFunta
Solution
tokio::net::windows::named_pipe::NamedPipeClientwrapper to be compatible withUnixStreamsplitmethod, only real implementation is inconnectSuccessfully tested after a bump in thread stack size
PR Checklist