-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the way you did it, it would actually not work
@@ -60,5 +60,5 @@ futures = ["futures-util", "futures-executor"] | |||
celo = ["ethers-core/celo"] | |||
ledger = ["coins-ledger", "futures", "semver"] | |||
yubi = ["yubihsm"] | |||
aws = ["rusoto_core", "rusoto_kms", "tracing", "spki"] | |||
aws = ["rusoto_core/rustls", "rusoto_kms/rustls", "tracing", "spki"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this unchanged
@@ -34,8 +34,8 @@ trezor-client = { version = "0.0.7", optional = true, default-features = false, | |||
] } | |||
|
|||
# aws | |||
rusoto_core = { version = "0.48.0", optional = true } | |||
rusoto_kms = { version = "0.48.0", optional = true } | |||
rusoto_core = { version = "0.48.0", default-features = false, optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rusoto_core = { version = "0.48.0", default-features = false, optional = true } | |
rusoto_core = { version = "0.48.0", default-features = false, optional = true, features = ["rustls"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be like this i think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like they are the same
Disable default native-tls feature on rusoto