Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: disable native-tls on rusoto #2021

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

rkrasiuk
Copy link
Contributor

@rkrasiuk rkrasiuk commented Jan 6, 2023

Disable default native-tls feature on rusoto

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the way you did it, it would actually not work

@@ -60,5 +60,5 @@ futures = ["futures-util", "futures-executor"]
celo = ["ethers-core/celo"]
ledger = ["coins-ledger", "futures", "semver"]
yubi = ["yubihsm"]
aws = ["rusoto_core", "rusoto_kms", "tracing", "spki"]
aws = ["rusoto_core/rustls", "rusoto_kms/rustls", "tracing", "spki"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave this unchanged

@@ -34,8 +34,8 @@ trezor-client = { version = "0.0.7", optional = true, default-features = false,
] }

# aws
rusoto_core = { version = "0.48.0", optional = true }
rusoto_kms = { version = "0.48.0", optional = true }
rusoto_core = { version = "0.48.0", default-features = false, optional = true }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rusoto_core = { version = "0.48.0", default-features = false, optional = true }
rusoto_core = { version = "0.48.0", default-features = false, optional = true, features = ["rustls"] }

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be like this i think?

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they are the same

@gakonst gakonst merged commit 7ddfd84 into gakonst:master Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants