Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: disable native-tls on rusoto #2021

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: disable native-tls on rusoto #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ethers-signers/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ trezor-client = { version = "0.0.7", optional = true, default-features = false,
] }

# aws
rusoto_core = { version = "0.48.0", optional = true }
rusoto_kms = { version = "0.48.0", optional = true }
rusoto_core = { version = "0.48.0", default-features = false, optional = true }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rusoto_core = { version = "0.48.0", default-features = false, optional = true }
rusoto_core = { version = "0.48.0", default-features = false, optional = true, features = ["rustls"] }

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be like this i think?

rusoto_kms = { version = "0.48.0", default-features = false, optional = true }
tracing = { version = "0.1.37", optional = true }
spki = { version = "0.6.0", optional = true }

Expand All @@ -60,5 +60,5 @@ futures = ["futures-util", "futures-executor"]
celo = ["ethers-core/celo"]
ledger = ["coins-ledger", "futures", "semver"]
yubi = ["yubihsm"]
aws = ["rusoto_core", "rusoto_kms", "tracing", "spki"]
aws = ["rusoto_core/rustls", "rusoto_kms/rustls", "tracing", "spki"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave this unchanged

trezor = ["trezor-client", "futures", "semver", "home"]