This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore: bump crypto deps #2260
Merged
chore: bump crypto deps #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
commented
Mar 13, 2023
gakonst
commented
Mar 13, 2023
|
took some effort but overall like the new APIs, love the flexibility. also finally got rid of the Sha digest signer, what a hack dear god - ty @tarcieri !! |
tarcieri
reviewed
Mar 15, 2023
Comment on lines
+43
to
+46
| if check_candidate(&sig, RecoveryId::from_byte(0).unwrap(), digest, vk) { | ||
| EthSig { r, s, v: 0 } | ||
| } else if check_candidate(&sig, RecoveryId::from_byte(1).unwrap(), digest, vk) { | ||
| EthSig { r, s, v: 1 } |
There was a problem hiding this comment.
A little late but the corresponding API for this in the ecdsa crate is RecoveryId::trial_recovery_from_prehash
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tarcieri I seem to be doing something wrong with the api as the ethers-core tests fail now, maybe it's theKeccak256::new_with_prefixcall?