Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement recoverable signatures for ECDSA-Secp256k1 #408

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Implement recoverable signatures for ECDSA-Secp256k1 #408

merged 2 commits into from
Mar 14, 2023

Conversation

agostbiro
Copy link
Contributor

Implement recoverable signatures for ECDSA-Secp256k1 signer and make PrehashSigner<Signature<Secp256k1>> return normalized s values.

No recoverable signature::Signer implementation for yubihsm::ecdsa::Signer since we can't implement signature::PrehashSignature for (Signature<Secp256k1>, RecoveryId).

There is a bit of a repetition now with the P-256 and P-384 implementations -- I could add a macro for them.

Related: gakonst/ethers-rs#2158, gakonst/ethers-rs#2260

@tony-iqlusion
Copy link
Member

This is probably the best you can do without specialization.

@tony-iqlusion tony-iqlusion merged commit 3e6cf9b into iqlusioninc:main Mar 14, 2023
@agostbiro agostbiro deleted the agostbiro/recoverable-ecdsa branch March 14, 2023 16:27
@tony-iqlusion tony-iqlusion mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-iqlusion tony-iqlusion tony-iqlusion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agostbiro @tony-iqlusion