This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a test to ensure contracts with underscore work.
The issue comes from
Inflector::to_snake_case
which removes the trailing leading and trailing_
, this does not impact the method selector though, only the rust function name, which could be a problem if a contract looks likebecause after
Inflector::to_snake_case
both functions are namehash_puzzle
,to_snake_case
is used in a bunch of places and could be a bit tedious to fixSolution
PR Checklist