This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: naming and default impl #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Dec 10, 2021
|
@mattsse All tests are passing for me. Not sure why those fail in the CI |
|
this looks like a solc issue, mb just a flake. After thinking about this again, this makes perfect sense, we're passing "london" as evm version to a "0.6.0" and that solc version probably doesn't know anything about "london" yet... should we bump solc in the CI @gakonst ? |
|
I'm 👍 to bump Solc in tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding some helpers for EvmVersion. Those will be useful when configuring the
SolcConfigbefore compiling aProject. This is theethers-rsPR to fix foundry-rs/foundry#202Solution
PR Checklist