feat(core): implemented signed transaction RLP decoding

[Rjected]

Motivation

There are often cases where we might have some RLP encoding of a transaction, for example when receiving P2P messages, and want to decode that into a transaction type.

Solution

This implements RLP decoding for signed transactions, extracting the signature from the decoding as well as building and returning the transaction. This also recovers the sender from the signature so we can populate the from field. This can error, so we introduce new error types (Eip1559RequestError, TypedTransactionError, RequestError) which also wrap errors we might encounter when decoding and recovering the sender.

This also introduces a hash method on TypedTransaction which returns the hash of the signed transaction's RLP encoding.

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog

[mattsse]

awesome!

before we merge this, mind having a look at this

https://github.com/gakonst/foundry/blob/71f9e89256815008b5e4e7f8de84513c13110793/node/node-core/src/eth/transaction.rs

that's part of the forge node PR foundry-rs/foundry#1037

whether we can somehow unify some things

[gakonst]

@Rjected have you had the chance to look at Matt's code above? Are there maybe more utils to add?

[gakonst]

(bump @Rjected)

[mattsse]

thanks @Rjected for the write up here foundry-rs/foundry#1037 (comment)

agree with most of that, current blocker is that I need to convert from foundry node TypedTransaction(Request) to ethers Transaction(Request), in order to reuse ether's signers.

I think for now I'll try to do conversion in both ways and figure out how to unify afterwards, because I believe it could be replaced with ethers' types eventually.

so my recommendation, get this PR and the node PR over the line individually and unify and clean up afterwards.

[gakonst]

lgtm if @mattsse thinks this is OK to merge as-is - need to fix minor conflict in changelog

[Rjected]

Cool, just fixed changelog, rebased

[gakonst]

based rebase, lgtm thank you for getting this over the line