This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
ethers-solc: fix build info default directory #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the default behavior for the `build-info` directory when it is unconfigured. It should end up in the configured artifacts directory, taking into account whatever the config for the artifacts directory is. If the build info is specifically configured, then that will take precendence over the default.
tynes
force-pushed
the
fix/build-info-default-dir
branch
from
ec5fe37
to
29de20c
Compare
|
Would super appreciate a merge and pull into foundry because this will fix our toolchain :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This commit fixes the default behavior for the
build-infodirectory when it is unconfigured. It should end up in
the configured artifacts directory, taking into account
whatever the config for the artifacts directory is.
If the build info is specifically configured, then that
will take precendence over the default.
Solution
Take into account the configured artifacts directory instead of using the default value
PR Checklist