This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: serialize slot as h256 66 byte string #1687
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref foundry-rs/foundry#2687
hardhat recently enforced 66byte slot argument for
eth_getStorageAt
NomicFoundation/hardhat#2581 because:this is a bit confusing to me because this spec https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getstorageat says it's a QUANTITY...
this is not very clear to meresolved here NomicFoundation/hardhat#2581 (comment)
we should merge this to be on par with hardhat
Solution
PR Checklist