Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some issues have been raised, reporting
WsServer
panics on upstream connection errors.#1889 #1815
ethers-rs/ethers-providers/src/transports/ws.rs
Lines 250 to 256 in 4b68562
Solution
In order to have a simpler and more predictable behavior, I believe the application should directly handle reconnections (also stated here), avoiding recovery mechanisms at the transport layer.
Instead of crashing the program, we gracefully close all active subscriptions. Clients will then observe the end of their streams and issue proper actions.
What do you guys think?
PR Checklist