Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add openssl and rustls feature flags in ethers-middleware #1961

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Dec 21, 2022

Motivation

I was working on a project with requirement to use OpenSSL, so I added this:

ethers = { version = "1.0.2", default-features = false, features = ["ws", "openssl"] }

But I noticed that rustls was still building.

Solution

The problem was that ethers-middleware was explicitly using reqwest with rustls-tls enabled, so I added rustls and openssl feature flags to it.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@oblique oblique force-pushed the fix-tls branch 2 times, most recently from d7e390e to 58bba8e Compare December 21, 2022 11:10
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…act-abigen

Without this fix, `rustls` was enabled by default even if user had `openssl` feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants