This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
concept ack, let's merge once the base is merged |
prestwich
force-pushed
the
prestwich/provider-layout-refactor
branch
3 times, most recently
from
February 17, 2023 17:07
e56a8af
to
bfb894d
Compare
needs rebase since we merged your middleware errors PR. lgtm otherwise and supportive |
prestwich
force-pushed
the
prestwich/provider-layout-refactor
branch
from
February 20, 2023 04:32
bfb894d
to
84aca0d
Compare
rebased and gitpilled |
docs suck less now, this should be ready to go :) |
DaniPopes
suggested changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very based. Nits
DaniPopes
approved these changes
Feb 20, 2023
gakonst
approved these changes
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2122
Cleans up the ethers-providers crate by organizing modules into a more clean layout.
TODONES:
update docs for existing modulesensure all modules are documented