This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(core): set miner.etherbase in clique mode #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ethereum/go-ethereum#26413 caused the default clique configuration for the GethInstance to fail to start, because we did not pass a `miner.etherbase` flag on startup * adds a `miner.etherbase` flag with the clique signer address as the argument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ethereum/go-ethereum#26413 caused the default clique configuration for the
GethInstanceto fail to start mining, because we did not pass a--miner.etherbaseflag on startup.For example, this would cause error logs in reth integration tests when we would try to start mining over RPC:
Solution
Adds a
--miner.etherbaseflag with the clique signer address as the argument, when clique is enabled.Ran reth integration tests multiple times after patching ethers
PR Checklist