-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
mv \ scripts/examples.sh \ bin/run_all_examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed in the release script. I'm still testing this but overall really nice work.
Can you also integrate this https://github.com/cargo-bins/release-pr, so we can start doing releases on cron weekly?
info "creating git commit" | ||
exec_or_print cargo release commit "${COMMON_FLAGS[@]}" $SIGN_COMMIT | ||
|
||
info "publishing crates" | ||
exec_or_print cargo release publish "${COMMON_FLAGS[@]}" "${WORKSPACE_FLAGS[@]}" | ||
|
||
info "tagging commits" | ||
cargo release tag "${COMMON_FLAGS[@]}" "${WORKSPACE_FLAGS[@]}" $SIGN_TAG | ||
|
||
info "pushing commits and tags to remote" | ||
cargo release push "${COMMON_FLAGS[@]}" "${WORKSPACE_FLAGS[@]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo release public/commit/tag/push
are not commands, is there a mistake here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is using this cargo extension? https://github.com/crate-ci/cargo-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I was on v0.20 looks like latest has more stuff!
I'm giving https://github.com/MarcoIeni/release-plz a try |
""" | ||
# template for the changelog body | ||
# https://tera.netlify.app/docs/#introduction | ||
body = """ | ||
{% if version %}\ | ||
## [{{ version | trim_start_matches(pat="v") }}] - {{ timestamp | date(format="%Y-%m-%d") }} | ||
{% else %}\ | ||
## [Unreleased] | ||
{% endif %}\ | ||
{% for group, commits in commits | group_by(attribute="group") %} | ||
### {{ group | title }} | ||
{% for commit in commits %} | ||
- {% if commit.breaking %}[**breaking**] {% endif %}{{ commit.message | upper_first | split(pat="\\n") | first }}\ | ||
{% endfor %} | ||
{% endfor %}\n | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance we can also add the PR author in the changelog?
beefd2b
to
44c7083
Compare
OK let's send it, updated my cargo-release command. Will revise with release-plz in the near future. |
Motivation
Solution
PR Checklist