This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: syn 2.0, merge eip712 crate into ethers-contract-derive #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mattsse
reviewed
Mar 25, 2023
mattsse
approved these changes
Mar 26, 2023
Comment on lines
+9
to
+11
| /// Parses the specified attributes from a `syn::Attribute` iterator. | ||
| macro_rules! parse_attributes { | ||
| ($attrs:expr, $attr_ident:literal, $meta:ident, $($field:pat, $opt:expr => $block:block)*) => { |
There was a problem hiding this comment.
syn 2 has a few breaking changes when it comes to extracting attributes, this seems like a useful helper to have
This was referenced Mar 30, 2023
|
is this a breaking change? can't quite tell if it moves the eip712 derive to a different place |
|
the crate won't be published anymore but the exports should be the same only breaking change is the removal of the "eip712" feature |
|
is it worth leaving the feature as a no-op for compatibility? |
DaniPopes
changed the title
Done |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/dtolnay/syn/releases/tag/2.0.0
Blocked by:
prettyplease (abigen formatting)Haven't updated yet (doesn't block):
Solution
Fix breaking changes, mainly:
input.parse_terminatedfrom turbofish to argumentAdditionally, moves
ethers-derive-eip712toethers-contract-derivedue to duplicated code and useless duplicated dependencies on ethers-core. Alsoremovesdeprecates the feature since it doesn't gate dependencies anymore.TODO
ethers_contract::it::contract::test_derive_eip712PR Checklist