-
Notifications
You must be signed in to change notification settings - Fork 795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level changes:
It would be good to route users to the abigen!
-based interfaces for accessing these tools, as they're simpler and higher level. This documentation is a good explanation of how abigen works under the hood
We should also mention the difference between Event::stream
and Event::subscribe
. the stream
interface is polling, and will work with any provider, but have increased cost and latency. Subscribe is based on WS/IPC notifications, and is limited to those providers
Thanks for the feedback, I went and made some of the easy changes. I have yet to distinguish the difference between |
did you intend to do this as part of this PR? or in a future one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is at risk of getting stale, I'm going to re-run CI and merge if succesful. Followup work can be a separate PR
CI failures unrelated |
I added some more to the documentation here
contributes to #2282