This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(core): Transaction::decode()
sets the hash
#2303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1849
Motivation
As stated in issue #1849, when the function
decode(rlp)
is used to build a transaction from its rlp serialization (i.e. raw transaction) the fieldhash
of the resultingTransaction
is not set (set to default value, hash 0x0).Solution
The
hash
field of the returnedTransaction
is calculated as thekeccak256
of the rlp bytes.The test for the correctness of this change can be run with
cargo test --package ethers-core types::transaction::response::tests::decode_tx_assert_hash
PR Checklist