This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
perf: early return in EthCodec derive #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Mar 29, 2023
| variant.span(), | ||
| "EthAbiType cannot be derived for enum variants with multiple fields", | ||
| )) | ||
| } |
There was a problem hiding this comment.
This was written weirdly, with also an unreachable block (fields.len() == 1 guarantees fields.iter().next() is Some, but an else block was present)
| @@ -205,45 +201,44 @@ fn tokenize_enum<'a>( | |||
|
|
|||
| let mut into_tokens = TokenStream::new(); | |||
| let mut from_tokens = TokenStream::new(); | |||
| for (idx, variant) in variants.into_iter().enumerate() { | |||
| let last = variants.size_hint().1.unwrap().saturating_sub(1); | |||
There was a problem hiding this comment.
consume in the last call instead of cloning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we go straight into decoding which can become expensive when called continuously from a big enum, eg foundry HEVM or HardhatConsole. We have the ParamType to decode so we can calculate very cheaply a minimum bound in bytes to check against
Solution
derive(EthCodec)TokenizableToken::Tupleof the wrong lengthVecsointo_iteris better thandrainPR Checklist