This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore: use ethers 2 by default when generating bindings #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/use-crates-release-by-default
branch
from
f2858a7
to
ee75915
Compare
|
Yeah I think that's fine if we switch foundry off of git as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
no that we have auto-releases, we can switch to using crates dep by default for generated bindings.
we can also depend on ethers from crates in foundry from now
wdyt @DaniPopes (harcoding the current major release is probably the easiest solution)
cc @leonardoalt
Solution
PR Checklist