Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

chore: dont retain errors #2332

Merged
merged 1 commit into from
Apr 10, 2023
Merged

chore: dont retain errors #2332

merged 1 commit into from
Apr 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Apr 6, 2023

Motivation

if we compile_exact(file) we should not filter errors because this obfuscates failed compile runs
discovered via:
foundry-rs/foundry#4467

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich requested a review from gakonst April 9, 2023 22:34
prestwich
prestwich reviewed Apr 9, 2023
View reviewed changes
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks fine, but I don't have the context to review its impact on things. cc @gakonst

gakonst
gakonst approved these changes Apr 10, 2023
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeh the error may be in another file which our file imports. Good catch.

@gakonst gakonst merged commit af99cb0 into gakonst:master Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prestwich prestwich prestwich left review comments

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @prestwich @gakonst