This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: document FilecoinMainnet as EIP-1559 compatible #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've noticed reading the source code that in the
Chain::is_legacymethodFilecoinHyperspaceTestnetwas listed as known EIP-1559 compatible whileFilecoinMainnetas unknown.I've restructured the code to reflect that
FilecoinMainnetis known to be EIP-1559 compatible as well. This is just a documentation change, since the value returned isfalsein both cases.Source official Filecoin blog: "EIP-1559 is implemented and live on the Filecoin mainnet."
Solution
PR Checklist