Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Feat/add withdrawals root #2348

Merged
merged 7 commits into from
Apr 24, 2023

Conversation

merklefruit
Copy link
Contributor

Motivation

Adds support for EIP-4895 and closes #2344

Solution

Add withdrawals_root property to the Block struct type.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're at it, let's also add the withdrawals field as well

ethers-core/src/types/block.rs Outdated Show resolved Hide resolved
@merklefruit
Copy link
Contributor Author

Added basic support for Withdrawal type and added it to the Block struct

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

ethers-core/src/types/withdrawal.rs Outdated Show resolved Hide resolved
ethers-core/src/types/block.rs Outdated Show resolved Hide resolved
ethers-core/src/types/block.rs Outdated Show resolved Hide resolved
ethers-core/src/types/block.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


/// A validator withdrawal from the consensus layer.
/// See EIP-4895: Beacon chain push withdrawals as operations.
#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit can derive

@gakonst gakonst merged commit 8e35a18 into gakonst:master Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP-4895: Add withdrawals_root field to Block struct
3 participants