This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(etherscan): Add get_block_by_timestamp to ethers-etherscan #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrainbowtrout
changed the title
|
Just a ping here -- No rush but didn't want it to fall off if you hadn't seen it. |
|
Fixed formatting from the failed clippy/fmt workflows. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Etherscan API has a blocks endpoint with a variety of useful methods. This PR incorporates the
get-block-number-by-timestampendpoint. I need to be able to fetch blocks by timestamps to evaluate blockchain state by timestamp and this seems like the best home for that functionality given theethers-etherscanmodule.Solution
Add the API endpoint.
PR Checklist
[ ] Breaking changes(No breaking changes)