This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BaseContract
provides various methods for decoding input data:decode
,decode_raw
,decode_with_selector
anddecode_with_selector_raw
.These methods take a method name as an argument, which could be omitted as it is already provided through input-data.
Solution
Add new methods that decode input-data without requiring method-name as a parameter -
decode_input_raw
anddecode_input
.Existing decode methods (
decode
,decode_raw
,decode_with_selector
anddecode_with_selector_raw
) lose functionality with the introduction of nameless decode methods. They could be removed unless I missed a viable utility or should be left in for backward compatibility.PR Checklist