Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Misc ws fixes #2389

Merged
merged 3 commits into from
May 7, 2023
Merged

Misc ws fixes #2389

merged 3 commits into from
May 7, 2023

Conversation

jordy25519
Copy link
Contributor

Motivation

Some small fixes found while going through the ws code

  • to_raw_valuehelper is slightly more efficient
  • ws ping frames are handled transparently by tungstenite

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes
Copy link
Collaborator

I don't believe to_raw_value and RawValue::from_string are equivalent, see failing tests in CI: https://github.com/gakonst/ethers-rs/actions/runs/4842761312/jobs/8748645910?pr=2389
Can you please check again?

@jordy25519
Copy link
Contributor Author

I don't believe to_raw_value and RawValue::from_string are equivalent, see failing tests in CI: https://github.com/gakonst/ethers-rs/actions/runs/4842761312/jobs/8748645910?pr=2389 Can you please check again?

needed to remove the escape \ chars, checked tests are passing now

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

@DaniPopes DaniPopes merged commit e9568eb into gakonst:master May 7, 2023
@jordy25519 jordy25519 deleted the misc-ws-fixes branch May 7, 2023 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants