This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: add ZkSync testnet #2391
Merged
feat: add ZkSync testnet #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agostbiro
commented
May 1, 2023
ethers-core/src/types/chain.rs
Outdated
| @@ -502,6 +506,9 @@ impl Chain { | |||
|
|
|||
| ZkSync => { | |||
| ("https://zksync2-mainnet-explorer.zksync.io/", "https://explorer.zksync.io/") | |||
| }, | |||
| ZkSyncTestnet => { | |||
| ("https://zksync2-testnet-explorer.zksync.dev/", "https://goerli.explorer.zksync.io/") | |||
There was a problem hiding this comment.
I added the explorer api (the first element of the tuple) for ZkSync testnet, because it's there for mainnet as well. But as far as a I can tell, the explorer API is not compatible with Etherescan, it only seems to support contract verification.
|
The failing CI tests seem unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ZkSync mainnet is among the supported chains, but the testnet is missing.
Solution
Added ZkSync testnet to the
Chainenum.PR Checklist