This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Remove the eip712 feature flag and have it enabled by default #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to set nightly - it was reverted with the next commit |
DaniPopes
approved these changes
May 9, 2023
|
Sorry I have overloaded the PR for clippy fixes as well |
DaniPopes
suggested changes
May 9, 2023
| @@ -58,6 +58,3 @@ legacy = [] | |||
|
|
|||
| rustls = ["ethers-contract-abigen/rustls"] | |||
| openssl = ["ethers-contract-abigen/openssl"] | |||
|
|
|||
| # Deprecated | |||
| eip712 = [] | |||
There was a problem hiding this comment.
Could you add them back here too?
| @@ -70,6 +70,3 @@ rand.workspace = true | |||
| celo = ["legacy"] # celo support extends the transaction format with extra fields | |||
| legacy = [] | |||
| macros = ["syn", "cargo_metadata", "once_cell"] | |||
|
|
|||
| # Deprecated | |||
| eip712 = [] | |||
prestwich
suggested changes
May 9, 2023
| @@ -10,10 +10,6 @@ other utilities for interacting with the Ethereum ecosystem | |||
|
|
|||
| For more information, please refer to the [book](https://gakonst.com/ethers-rs). | |||
|
|
|||
| ## Feature flags | |||
|
|
|||
| - `eip712`: Provides the `Eip712` trait and derive procedural macro for EIP-712 encoding of typed data. | |||
There was a problem hiding this comment.
modify to say "does nothing"
| @@ -69,7 +69,6 @@ impl fmt::Display for Signature { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "eip712")] | |||
There was a problem hiding this comment.
combine with main impl block
dbelv
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2408
Solution
Remove feature flag enabling by default.
PR Checklist