This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(core): Utility to detect Shanghai-enabled chains #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
May 25, 2023
ethers-core/src/types/chain.rs
Outdated
| @@ -360,6 +360,13 @@ impl Chain { | |||
| } | |||
| } | |||
|
|
|||
| pub const fn is_shanghai(&self) -> bool { | |||
There was a problem hiding this comment.
needs docs, and I think we settled on supports_push0
DaniPopes
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to better handle EVM discrepancies between different chains (see foundry-rs/foundry#748). One of these things would be a little utility on the
Chaintype to quickly detect if a chain is Shanghai-enabled or not.Solution
Adds the utility
PR Checklist