This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
ci: add more feature tests and checks #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
May 27, 2023
There was a problem hiding this comment.
Not caught in CI previously (#2406)
There was a problem hiding this comment.
Some fields missing when deserializing the EthInfo struct, so a test was failing.
There was a problem hiding this comment.
Cannot enable dev-dep features
DaniPopes
commented
May 27, 2023
Comment on lines
27
to
+32
| - name: no default features | ||
| flags: --workspace --no-default-features | ||
| flags: --no-default-features | ||
| - name: default features | ||
| flags: --workspace | ||
| flags: "" | ||
| - name: all features | ||
| flags: --workspace --all-features | ||
| flags: --all-features |
There was a problem hiding this comment.
--workspace is not needed, because the only crates that are not included are the example ones, which are tested in another job. This allows removing the windows hacks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist