This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Recognize localdev.me as "local" domain #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Sep 30, 2023
DaniPopes
approved these changes
Sep 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running an application in k8s locally it is common to use
localdev.medomain for ingress, as documented in ingress-nginx docs. This is a domain owned by Amazon which DNS points to127.0.01, can be considered stable. Ethers-rs, however, doesn't recognize this as a local chain.My primary motivation here is for polling in foundry to have local polling behavior running against a local k8s cluster.
Solution
Update the
is_local_endpointrules to recognizelocaldev.meas local chain.PR Checklist